Differential D27196

Reload all kind of KHC addresses when the font size changed
ClosedPublic
Actions

Authored by yurchor on Feb 6 2020, 6:00 PM.

Details

Reviewers
ltoscano
Group Reviewers
KDE Applications
Commits
R125:ea387e967d8d: Reload all kind of KHC addresses when the font size changed
Summary

Previous approach was oversimplified and did not account all possible cases (autogenerated doc lists and glossaries).

BUG: 417222

Test Plan
  1. Open KHelpCenter.
  2. Double click on "Application manuals" in the sidebar.
  3. Click on "Increase font sizes" or "Decrease font sizes" button in toolbar.
  4. Font should be changed as expected.
  5. Open some manual, repeat 3.
  6. Open some glossary entry, repeat 3.
  7. Font size change should be fine.

Diff Detail

Repository
R125 KHelpCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Feb 6 2020, 6:00 PM
Restricted Application added a project: Documentation. · View Herald TranscriptFeb 6 2020, 6:00 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
yurchor requested review of this revision.Feb 6 2020, 6:00 PM
ltoscano added a subscriber: ltoscano.Feb 6 2020, 7:16 PM

Couldn't the duplicate code be moved to its own private method?

yurchor updated this revision to Diff 75128.Feb 6 2020, 7:28 PM

Put the reload page code into a separate private method

ltoscano accepted this revision as: ltoscano.Feb 7 2020, 4:24 PM

Thanks!

This revision is now accepted and ready to land.Feb 7 2020, 4:24 PM
Closed by commit R125:ea387e967d8d: Reload all kind of KHC addresses when the font size changed (authored by yurchor). · Explain WhyFeb 7 2020, 4:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mview.h (3 lines)
Mview.cpp (13 lines)

Diff 75181

View Options

view.h

Loading...
View Options

view.cpp

Loading...