Differential D2719

[System Tray] Call Qt.createComponent for PlasmoidItem only once
ClosedPublic
Actions

Authored by broulik on Sep 9 2016, 7:51 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:4819739af82e: [System Tray] Call Qt.createComponent for PlasmoidItem only once
R871:4819739af82e: [System Tray] Call Qt.createComponent for PlasmoidItem only once
Test Plan

I slapped a console.time in there and it would show 1ms even on some of the subsequent invocations, so while QML engine should do some caching magic, calling it once is better anway.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6570.Sep 9 2016, 7:51 AM
broulik retitled this revision from to [System Tray] Call Qt.createComponent for PlasmoidItem only once.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 9 2016, 7:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 9 2016, 8:58 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Sep 9 2016, 8:58 AM
Closed by commit R120:4819739af82e: [System Tray] Call Qt.createComponent for PlasmoidItem only once (authored by broulik). · Explain WhySep 12 2016, 1:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6657

View Options

applets/systemtray/package/contents/ui/main.qml

Loading...