Port QRegExp to QRegularExpression
ClosedPublic

Authored by ahmadsamir on Feb 5 2020, 8:58 PM.

Details

Summary

In kgpgOptions::updateWidgets(), I assumed "[0-9A-Fa-F]" had a typo and
replaced the last "F" with "f".

Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern(),
except in KGpgGroupNodePrivate::groupPattern() as the pattern is already
anchored with ^ and $.

Test Plan

make && ctest

Diff Detail

Repository
R358 KGpg
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir requested review of this revision.Feb 5 2020, 8:58 PM
ahmadsamir created this revision.
dakon requested changes to this revision.Mar 16 2020, 9:34 PM

Thanks for the reminder, this sadly got lost in my inbox.

kgpgoptions.cpp
85

Please remove the extra spaces here, and at a few other places below that you have touched.

This revision now requires changes to proceed.Mar 16 2020, 9:34 PM
ahmadsamir updated this revision to Diff 77802.Mar 17 2020, 5:31 AM

Remove extra spaces

ahmadsamir marked an inline comment as done.Mar 17 2020, 5:33 AM
ahmadsamir added inline comments.
kgpgoptions.cpp
85

I was matching the existing style.

Anyhow I changed them. :)

dakon accepted this revision.Mar 17 2020, 1:36 PM
This revision is now accepted and ready to land.Mar 17 2020, 1:36 PM
This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.