Make the virtual keyboard disappear when locking the screen
ClosedPublic

Authored by tfella on Feb 5 2020, 3:35 PM.

Details

Summary

Previously, the virtual keyboard did not close when locking the screen, instead blocking part of the lockscreen while not actually working. This patch actually makes the keyboard close before locking

Test Plan

Open virtual keyboard -> Lock Screen -> No keyboard shown

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tfella created this revision.Feb 5 2020, 3:35 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2020, 3:35 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
tfella requested review of this revision.Feb 5 2020, 3:35 PM
apol added a subscriber: apol.Feb 5 2020, 4:03 PM

+1 makes sense to me.

davidedmundson added inline comments.
virtualkeyboard.cpp
295

Why is this needed now but not before?

tfella added inline comments.Feb 5 2020, 10:24 PM
virtualkeyboard.cpp
295

Apparently, inputMethod()->hide() does not actually close the keyboard, I think it's related to the input still being focused when the screen is locked. Calling m_inputWindow->hide() does close the keyboard however.

davidedmundson accepted this revision.Feb 6 2020, 8:35 AM
This revision is now accepted and ready to land.Feb 6 2020, 8:35 AM
This revision was automatically updated to reflect the committed changes.