Differential D2717

ErrorOverlay: fix dialogs being disabled by the mainwindow
ClosedPublic
Actions

Authored by dfaure on Sep 8 2016, 11:36 PM.

Details

Reviewers
vkrause
dvratil
Commits
R165:4e5c3eb76d70: ErrorOverlay: fix dialogs being disabled by the mainwindow
Summary

Testcase: open "jump to folder", cancel, restart akonadi,
reopen the dialog, it was disabled.

This happened because disabling the window actually disables
the child dialog too, so the saved state for the dialog was
"disabled". The fix is to save the "explicitly disabled" state
rather than isDisabled(). Thanks to Volker for helping me figure
this out.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 6566.Sep 8 2016, 11:36 PM
dfaure retitled this revision from to ErrorOverlay: fix dialogs being disabled by the mainwindow.
dfaure updated this object.
dfaure added reviewers: vkrause, dvratil.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 8 2016, 11:36 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause accepted this revision.Sep 10 2016, 12:58 PM
vkrause edited edge metadata.
This revision is now accepted and ready to land.Sep 10 2016, 12:58 PM
Closed by commit R165:4e5c3eb76d70: ErrorOverlay: fix dialogs being disabled by the mainwindow (authored by dfaure). · Explain WhySep 10 2016, 1:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgets/erroroverlay.cpp (4 lines)

Diff 6613

View Options

src/widgets/erroroverlay.cpp

Loading...