Make support for full screen mode optional
ClosedPublic

Authored by zzag on Feb 5 2020, 9:09 AM.

Details

Summary

In long term, we want to split XdgShellClient into several classes. One
class for xdg-toplevel clients, and the other one for xdg-popup clients.

xdg-popup clients are much simpler than xdg-toplevel clients, they can't
be maximized or shown in full screen mode, they can't be interactively
moved on the screen, and so on. In the end, we will have to plumb many
pure virtual methods, which looks a bit ugly.

This change makes support for full screen mode in AbstractClient optional
so we don't have to add those no-op methods and keep code more or less
"clean."

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Feb 5 2020, 9:09 AM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 5 2020, 9:09 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 5 2020, 9:09 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.