Differential D27159

Moved the header to the bottom
AbandonedPublic
Actions

Authored by niccolove on Feb 4 2020, 7:58 PM.

Details

Reviewers
None
Group Reviewers
VDG
Maniphest Tasks
T10470: Improve the visuals of tray popups
Summary

Moved the header to the bottom, according to T10470

Test Plan

After:

Diff Detail

Repository
R120 Plasma Workspace
Branch
move_header_to_bottom (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22065
Build 22083: arc lint + arc unit
niccolove created this revision.Feb 4 2020, 7:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2020, 7:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 4 2020, 7:58 PM
niccolove edited the test plan for this revision. (Show Details)Feb 4 2020, 7:58 PM
niccolove added a reviewer: VDG.
niccolove added a task: T10470: Improve the visuals of tray popups.
ngraham added a subscriber: ngraham.Feb 4 2020, 8:20 PM
ngraham added inline comments.
applets/batterymonitor/package/contents/ui/PopupDialog.qml
124

Now it's a footer, not a header

filipf added a subscriber: filipf.Feb 4 2020, 8:35 PM
filipf added inline comments.
applets/batterymonitor/package/contents/ui/PopupDialog.qml
144

isn't width already defined by using anchors.left and anchors.right?

broulik added a subscriber: broulik.Feb 5 2020, 9:46 AM

Same issue as with notifications: the PowerManagementItem shows inhibition info and other state, which makes the position of the checkbox non-deterministic

ngraham added a comment.Feb 5 2020, 3:16 PM

There's a more exhaustive change in D26806: [Applets/Power Manager] Update layout based on T10470 already; perhaps we should focus our efforts there?

niccolove abandoned this revision.Apr 9 2020, 9:41 PM

Revision Contents
Changeset List

Diff 75011

View Options

applets/batterymonitor/package/contents/ui/PopupDialog.qml

Loading...