Differential D27158

Fix some compiler warnings
ClosedPublic
Actions

Authored by ahmadsamir on Feb 4 2020, 6:36 PM.

Details

Reviewers
dfaure
apol
Group Reviewers
Frameworks
Commits
R237:fb29718d3ac6: Fix some compiler warnings
Summary
  • Fix order of member initialisation (compiling with -Wreorder)
  • Use Q_UNUSED where needed
  • QAtomicInteger::loadRelaxed() has been available since Qt 5.14
Test Plan

make && ctest

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Feb 4 2020, 6:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 4 2020, 6:36 PM
ahmadsamir requested review of this revision.Feb 4 2020, 6:36 PM
dfaure added inline comments.Feb 4 2020, 10:32 PM
src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
33

missing space before m_baseDir

ahmadsamir updated this revision to Diff 75028.Feb 5 2020, 8:10 AM

Add missing space after ,

dfaure accepted this revision.Feb 8 2020, 10:29 AM
This revision is now accepted and ready to land.Feb 8 2020, 10:29 AM
Closed by commit R237:fb29718d3ac6: Fix some compiler warnings (authored by ahmadsamir). · Explain WhyApr 21 2020, 11:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 80754

View Options

src/kconfig_compiler/KConfigCodeGeneratorBase.cpp

Loading...
View Options

src/kconfig_compiler/KConfigXmlParser.cpp

Loading...
View Options

src/kconfig_compiler/kconfig_compiler.cpp

Loading...