Details
- Reviewers
ervin crossi meven - Group Reviewers
Plasma - Commits
- R119:d28337b6d379: KCM Fonts port anti aliasing part to KPropertySkeletonItem
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 22344 Build 22362: arc lint + arc unit
kcms/fonts/fonts.cpp | ||
---|---|---|
201 ↗ | (On Diff #75000) | antiAliasingItem->isSaveNeeded() ? |
kcms/fonts/fontssettingsaa.cpp | ||
154 ↗ | (On Diff #75000) | static_cast<> instead of c-style cast Also, you can move closer the declaration of spType |
161 ↗ | (On Diff #75000) | static_cast<> instead of c-style cast Also, you can move closer the declaration of hStyle |
kcms/krdb/krdb.cpp | ||
774 ↗ | (On Diff #75000) | static_cast<> |
788 ↗ | (On Diff #75000) | static_cast<> |
kcms/fonts/package/contents/ui/main.qml | ||
---|---|---|
242 ↗ | (On Diff #75000) | I am really away from qml thing but are you sure this one correct ? I mean isnt this should be |
kcms/fonts/package/contents/ui/main.qml | ||
---|---|---|
242 ↗ | (On Diff #75000) | No dpi is declared inside fontsAASettings |
kcms/fonts/fonts.cpp | ||
---|---|---|
131 ↗ | (On Diff #75000) | Please no C cast, use static_cast instead. |
136 ↗ | (On Diff #75000) | ditto (and no space after *) |
kcms/fonts/fontsaasettings.cpp | ||
70 ↗ | (On Diff #75465) | Wrong indentation |
224 ↗ | (On Diff #75465) | I'd go for the enums all the way until here of course |
kcms/fonts/fontsaasettings.h | ||
35 ↗ | (On Diff #75465) | Why int here and for the next property and not the enum types directly? This would avoid the static_cast in KRDB. |
Fix reset and default button for Anti Aliasing area (states were ok, but UI values were not updated after clicking them)
depends on https://phabricator.kde.org/D27342
kcms/fonts/fonts.cpp | ||
---|---|---|
136 ↗ | (On Diff #75000) | This C cast is unnecessary. Also the * is merely redundant with auto (you can keep it but it's not necessary). |
kcms/fonts/fontsaasettings.cpp | ||
---|---|---|
305 ↗ | (On Diff #75813) | add space between if and ( please |