Differential D27154

KCM/solid-actions convert foreach
ClosedPublic
Actions

Authored by meven on Feb 4 2020, 1:52 PM.

Details

Reviewers
ervin
davidedmundson
Group Reviewers
Plasma
Commits
R119:5bb3ebc94d82: KCM/solid-actions convert foreach

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Feb 4 2020, 1:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 4 2020, 1:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Feb 4 2020, 1:52 PM
davidedmundson accepted this revision.Feb 4 2020, 1:54 PM
This revision is now accepted and ready to land.Feb 4 2020, 1:54 PM
meven updated this revision to Diff 74995.Feb 4 2020, 2:58 PM

Add a missing space

Closed by commit R119:5bb3ebc94d82: KCM/solid-actions convert foreach (authored by meven). · Explain WhyFeb 4 2020, 2:59 PM
This revision was automatically updated to reflect the committed changes.
broulik added a subscriber: broulik.Feb 4 2020, 3:04 PM
broulik added inline comments.
kcms/solid_actions/ActionItem.cpp
143

Don't iterate values(), which creates a temporary list, instead use iterators.

broulik added inline comments.Feb 4 2020, 3:05 PM
kcms/solid_actions/ActionItem.cpp
143

Ok, probably not, since this is a QHash with insertMulti...

meven marked 2 inline comments as done.Mar 13 2020, 8:54 AM

Revision Contents
Changeset List

Diff 74996

View Options

kcms/solid_actions/ActionItem.cpp

Loading...
View Options

kcms/solid_actions/ActionModel.cpp

Loading...
View Options

kcms/solid_actions/DesktopFileGenerator.cpp

Loading...
View Options

kcms/solid_actions/SolidActionData.cpp

Loading...
View Options

kcms/solid_actions/SolidActions.cpp

Loading...