As per T10470, I moved the notification do not disturb buttons to the bottom
Details
Details
- Reviewers
ngraham broulik - Group Reviewers
Plasma - Maniphest Tasks
- T10470: Improve the visuals of tray popups
How it is now:
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- bottom_notification_options (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22030 Build 22048: arc lint + arc unit
Comment Actions
Calling it footer would be more appropriate now instead of header.
But when there is a separate qml, it is called Toolbar.
And other applets(e.g. volume), don't mention any name.
Can we choose a single name(or style)?
Comment Actions
just a minor thing I noticed, rest looks good
| applets/notifications/package/contents/ui/FullRepresentation.qml | ||
|---|---|---|
| 422 | added row is fine but there are 4 spaces added here | |
Comment Actions
My biggest gripe with merely moving the controls to the bottom is that many plasmoids show additional information in the header, which will cause the controls to shift around and their position unpredictable.
While do not disturb is on the checkbox is further up than normal.
| applets/notifications/package/contents/ui/FullRepresentation.qml | ||
|---|---|---|
| 464 | The menu placement is quite odd now, it should open upwards. | |