moved do not disturb to the bottom
Needs RevisionPublic

Authored by niccolove on Feb 3 2020, 8:52 PM.

Details

Reviewers
ngraham
broulik
Group Reviewers
Plasma
Maniphest Tasks
T10470: Improve the visuals of tray popups
Summary

As per T10470, I moved the notification do not disturb buttons to the bottom

Test Plan

How it is now:

Diff Detail

Repository
R120 Plasma Workspace
Branch
bottom_notification_options (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22066
Build 22084: arc lint + arc unit
niccolove created this revision.Feb 3 2020, 8:52 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2020, 8:52 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
niccolove requested review of this revision.Feb 3 2020, 8:52 PM
niccolove edited the test plan for this revision. (Show Details)Feb 3 2020, 8:52 PM
niccolove added a project: VDG.
ngraham accepted this revision.Feb 3 2020, 10:05 PM
ngraham added reviewers: broulik, Plasma.
This revision is now accepted and ready to land.Feb 3 2020, 10:05 PM
gvgeo added a subscriber: gvgeo.Feb 4 2020, 4:17 AM

Calling it footer would be more appropriate now instead of header.

But when there is a separate qml, it is called Toolbar.
And other applets(e.g. volume), don't mention any name.
Can we choose a single name(or style)?

+1 for calling it a "footer."

niccolove updated this revision to Diff 75012.Feb 4 2020, 8:02 PM

Renamed header to footer

filipf added a subscriber: filipf.Feb 4 2020, 8:38 PM

just a minor thing I noticed, rest looks good

applets/notifications/package/contents/ui/FullRepresentation.qml
422

added row is fine but there are 4 spaces added here

broulik requested changes to this revision.Feb 5 2020, 8:30 AM

My biggest gripe with merely moving the controls to the bottom is that many plasmoids show additional information in the header, which will cause the controls to shift around and their position unpredictable.
While do not disturb is on the checkbox is further up than normal.

applets/notifications/package/contents/ui/FullRepresentation.qml
464

The menu placement is quite odd now, it should open upwards.

This revision now requires changes to proceed.Feb 5 2020, 8:30 AM