/usr/bin/kinfocenter doesn't match "kinfocenter"
it also cannot be using as the binaryName in the rest of this method.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma - Commits
- R124:a1d44475d4be: Handle spawning kinfocenter with a full path
Launched
systemsettings5
kinfocenter
/opt/kde5/bin/kinfocenter
Diff Detail
Diff Detail
- Repository
- R124 System Settings
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| app/main.cpp | ||
|---|---|---|
| 42 | This will consider also /usr/bin/my-kinfocenter as kinfocenter, which is definitely not what you want. | |
Comment Actions
If you run /usr/bin/my-kinfocenter you wouldn't spawn this executable in the first place
Comment Actions
If you manually create a symlink called my-kinfocenter that points to systemsettings then clearly you're actually trying to make kinfocenter open just with a different binary name for your own convenience, so this new code is actually more correct.
Comment Actions
Hello symlink my old friend...
Well sure, but not from something we ship.
We don't "definitely" want systemsettings mode either, and it has to be one of the two.
Right now it's definitely broken.
@pino do you have any viable counter proposals?
Comment Actions
I'm going to ship this as it fixes an easy to hit bug that is definitely wrong.
I'm not trying to ingore any other proposals, we can always expand and change.