Differential D27125

Rename popupPosition to popupRect
ClosedPublic
Actions

Authored by zzag on Feb 3 2020, 12:51 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:84f0d51f4052: Rename popupPosition to popupRect
Summary

popupPosition implies that it is a QPoint, which is false.

Test Plan

Compiles.

Diff Detail

Repository
R108 KWin
Branch
rename-popup-position-to-popup-rect
Lint
Lint SkippedExcuse: asdf
Unit
No Unit Test Coverage
Build Status
Buildable 22005
Build 22023: arc lint + arc unit
zzag created this revision.Feb 3 2020, 12:51 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 3 2020, 12:51 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Feb 3 2020, 12:51 PM
davidedmundson accepted this revision.Feb 3 2020, 12:52 PM
This revision is now accepted and ready to land.Feb 3 2020, 12:52 PM
Closed by commit R108:84f0d51f4052: Rename popupPosition to popupRect (authored by zzag). · Explain WhyFeb 3 2020, 12:53 PM
This revision was automatically updated to reflect the committed changes.
apol added a subscriber: apol.Feb 3 2020, 5:51 PM

You have told me several times you don't want shortened names on KWin. Therefore it should be popupRectangle. Or rather popupGeometry.

Revision Contents
Changeset List

PathPackages
Mxdgshellclient.cpp (50 lines)

Diff 74921

View Options

xdgshellclient.cpp

Loading...