Add a default provider (as per documentation)
ClosedPublic

Authored by leinir on Feb 3 2020, 11:43 AM.

Details

Summary

Prior to this patch, without the KDE Platform Dependent, Attica
would fail to correctly initialise providers from KNewStuff which
were made according to the documentation in KNewStuff when run
in systems which did not have Plasma Desktop installed (which is
what provides the above mentioned platformdependent). With this
patch, while saving and restoring such information doesn't work,
at least they will work as intended.

This removes the need for including the provider URL in our own
released knsrc files, when it is explicitly suggested that it
should not be required.

Note: The documented method will work just fine for any
Plasma Desktop provided ones already, as any Plasma install
will have the correct plugin, but for any other file, this really
should still work the way the documentation says it is
supposed to.

See this email for some further context:
https://mail.kde.org/pipermail/kde-frameworks-devel/2020-January/102643.html

Diff Detail

Repository
R235 Attica
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Feb 3 2020, 11:43 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 3 2020, 11:43 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Feb 3 2020, 11:43 AM
leinir edited the summary of this revision. (Show Details)Feb 3 2020, 11:46 AM
leinir added reviewers: kossebau, Frameworks, KNewStuff.
leinir updated this revision to Diff 74917.Feb 3 2020, 12:14 PM
  • Use more modern style for the list initialisation
apol accepted this revision.Feb 3 2020, 6:35 PM
apol added a subscriber: apol.

LGTM

This revision is now accepted and ready to land.Feb 3 2020, 6:35 PM
This revision was automatically updated to reflect the committed changes.