Limit label maximum width, to avoid breaking UI.
Change label to use plasma components 3, for theme color compatibility.
Use of implicit sizes, to avoid binding loops.
BUG: 417074
BUG: 417106
drosca | |
ngraham | |
davidedmundson |
Plasma | |
VDG |
Limit label maximum width, to avoid breaking UI.
Change label to use plasma components 3, for theme color compatibility.
Use of implicit sizes, to avoid binding loops.
BUG: 417074
BUG: 417106
Use applet outside of systemtray and limit it's width.
If device description is not long enough, enable in the configuration
"Add virtual output device for simultaneous output on all local sound cars".
Before: Hamburger menu moves to the right, and there is no eliding.
After: Proper display.
No Linters Available |
No Unit Test Coverage |
Buildable 22042 | |
Build 22060: arc lint + arc unit |
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
109 | With testing I found 5 pixel spacing. But couldn't trace where it comes from, maybe padding around items?. Used smallSpacing instead to avoid another magic number. |
@ davidedmundson Is this monstrosity correct? I tried to avoid binding loops by setting minimum maximum sizes. And the origin of the values is contextMenuButton.implicitHeight.
Never mind, it was simplified.
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
129 | This will also solve the complexity of this patch. |
Tried couple themes, but could not reproduce the color problem. https://bugs.kde.org/show_bug.cgi?id=417106
Hopefully this change make sense.
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
127 | Is this all it needs to fix text color bug? |
applet/contents/ui/ListItemBase.qml | ||
---|---|---|
116 | Replace this line with Layout.fillWidth: true. This works because soloLabel and defaultButton will never be visible at the same time; when soloLabel isn't visible, then the radio button's label will be the item that's filling the width. |
It works like you said. The problem is that will be too easy, accidentally to change the default device. It is not right for the empty space, without any indication, to change your device.
Ah I see why you did it then. That makes some sense. Can you add a comment explaining this?