Differential D27116

KCM/Component email: simplify code
ClosedPublic
Actions

Authored by meven on Feb 3 2020, 9:24 AM.

Details

Reviewers
ervin
bport
crossi
Group Reviewers
Plasma
Commits
R119:3d2dfabe5509: KCM/Component email: simplify code
Summary

Clean up adding entries for Added Associations section of mimeapplist
Just find the application set if it is not found by the normal query.
Also add a constant and reuse one.

Diff Detail

Repository
R119 Plasma Desktop
Branch
arcpatch-D27116
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22586
Build 22604: arc lint + arc unit
meven created this revision.Feb 3 2020, 9:24 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 3 2020, 9:24 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Feb 3 2020, 9:24 AM
meven retitled this revision from KCM/Component email: simplify code, add a const to KCM/Component email: simplify code.Feb 3 2020, 9:25 AM
meven edited the summary of this revision. (Show Details)
ervin requested changes to this revision.Feb 12 2020, 1:20 PM

Tiny code style breakage

kcms/componentchooser/componentchooseremail.cpp
85

The spaces should be added back before the 1 on both lines.

This revision now requires changes to proceed.Feb 12 2020, 1:20 PM
meven updated this revision to Diff 75846.Feb 17 2020, 4:50 PM
meven marked an inline comment as done.

Fix a couple missing spaces

bport accepted this revision.Feb 20 2020, 8:45 AM
ervin accepted this revision.Feb 24 2020, 11:07 AM
This revision is now accepted and ready to land.Feb 24 2020, 11:07 AM
Closed by commit R119:3d2dfabe5509: KCM/Component email: simplify code (authored by meven). · Explain WhyFeb 25 2020, 4:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 75846

View Options

kcms/componentchooser/componentchooseremail.cpp

Loading...