Delete cache when resetting user settings
Needs RevisionPublic

Authored by filipf on Feb 2 2020, 11:48 PM.

Details

Reviewers
davidedmundson
Summary

Apparently SDDM's cache is not always allowing for a clean reset of user theming preferences so we can delete it when performing the reset.

BUG: 417057
FIXED-IN: 5.18.0

Test Plan

The folder was deleted (but got created again by SDDM when logging in again)

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Branch
delete-sddm-cache (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21981
Build 21999: arc lint + arc unit
filipf created this revision.Feb 2 2020, 11:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 2 2020, 11:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Feb 2 2020, 11:48 PM
davidedmundson requested changes to this revision.Feb 2 2020, 11:54 PM

Can you explain what happens that would require us to delete the cache and why this isn't the case when you change colour themes on a regular session.

This revision now requires changes to proceed.Feb 2 2020, 11:54 PM
filipf added a comment.Feb 3 2020, 9:13 AM

Can you explain what happens that would require us to delete the cache and why this isn't the case when you change colour themes on a regular session.

The difference is that we don't change the color scheme when resetting SDDM user settings, we delete kdeglobals. In a regular session the color scheme entry only gets updated, not deleted.

I see that it could be suggested that we reset the colors to Breeze instead of deleting them, but I know some distributions (e.g. Manjaro) hack SDDM theming from somewhere else so we shouldn't override that. SDDM's default state is an empty .config dir anyway.

Back to the issue at hand - these theme cache files seem unreadable to me, but what I presume happens is that a Plasma theme gets generated with a specific color scheme and when there is no other color scheme specified to recolor the Plasma theme, the cached theme recolored with old colors ends up being used.