Since KConfigWatcher automatically reparses configuration on change, this call is redundant.
Details
Details
- Reviewers
- None
- Group Reviewers
Plasma
Check if config changes are detected by changing decoration buttons order
Diff Detail
Diff Detail
- Repository
- R99 KDE Gtk Configuration Tool
- Branch
- remove-reparse-config (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21977 Build 21995: arc lint + arc unit
Comment Actions
You need to be careful here.
Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher.
In those cases, you will have to reparse.
Comment Actions
OK, so that makes 90% of this diff pointless :) Only the decorations button order change are triggered by KConfigWatcher. Would it make sense to port other methods to be triggered by corresponding KConfigWatchers or would it slow down the whole process of syncing settings significantly?
Comment Actions
Would it make sense to port other methods to be triggered by corresponding KConfigWatchers
Absolutely.
It means changing some stuff upstream to emit the change notifications, but it's the direction I want to take us.