Differential D2710

KMKernel: use the global identitymanager rather than creating another one
ClosedPublic
Actions

Authored by dfaure on Sep 8 2016, 1:08 PM.

Details

Reviewers
mlaurent
Commits
R43:3bbd5447d5f3: KMKernel: use the global identitymanager rather than creating another one
Test Plan

I've been using that patch for a month or so, no regressions detected.

Diff Detail

Repository
R43 KDE PIM
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure updated this revision to Diff 6547.Sep 8 2016, 1:08 PM
dfaure retitled this revision from to KMKernel: use the global identitymanager rather than creating another one.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a reviewer: mlaurent.
dfaure added a subscriber: KDE PIM.
Restricted Application added a project: KDE PIM. · View Herald TranscriptSep 8 2016, 1:08 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
mlaurent requested changes to this revision.Sep 9 2016, 6:57 AM
mlaurent edited edge metadata.

why not reduce to

KIdentityManagement::IdentityManager *KMKernel::identityManager()
​{
​ return KIdentityManagement::IdentityManager::self();
​}
?
and removing mIdentityManager pointer ?

This revision now requires changes to proceed.Sep 9 2016, 6:57 AM
dfaure added a comment.Sep 10 2016, 1:06 PM

Very good point.

dfaure updated this revision to Diff 6614.Sep 10 2016, 1:06 PM
dfaure edited edge metadata.

Remove mIdentityManager

mlaurent accepted this revision.Sep 10 2016, 1:49 PM
mlaurent edited edge metadata.

+2 :)

This revision is now accepted and ready to land.Sep 10 2016, 1:49 PM
Closed by commit R43:3bbd5447d5f3: KMKernel: use the global identitymanager rather than creating another one (authored by dfaure). · Explain WhySep 10 2016, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkmail/src/kmkernel.h (1 line)
Mkmail/src/kmkernel.cpp (6 lines)

Diff 6615

View Options

kmail/src/kmkernel.h

Loading...
View Options

kmail/src/kmkernel.cpp

Loading...