Differential D27093

Provide better name for GTK Settings Sync service
ClosedPublic
Actions

Authored by gikari on Feb 1 2020, 8:32 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R99:ddc9187adbc5: Provide better name for GTK Settings Sync service
Summary

Before:

After:

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gikari created this revision.Feb 1 2020, 8:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 1 2020, 8:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Feb 1 2020, 8:32 PM
gikari edited the summary of this revision. (Show Details)Feb 1 2020, 8:32 PM
gikari added a reviewer: VDG.
gikari edited the summary of this revision. (Show Details)
davidre added a subscriber: davidre.Feb 1 2020, 9:42 PM

I would drop the KDE/Qt Part because the settings are not specific to them but general settings and this service is needed to apply those settings to some applications. So "Applies Settings to Gnome/GTK applications'

nicolasfella added a subscriber: nicolasfella.Feb 1 2020, 10:22 PM

+1 (speaking as the one who introduced the name IIRC)

ngraham added a subscriber: ngraham.Feb 1 2020, 10:30 PM
ngraham added inline comments.
kded/gtkconfig.json
3

GNOME/GTK

gikari updated this revision to Diff 75568.Feb 12 2020, 6:50 PM

Capitalize GNOME and remove KDE/Qt part

gikari marked an inline comment as done.Feb 12 2020, 6:50 PM
gikari updated this revision to Diff 75569.Feb 12 2020, 6:53 PM

Remove "Appearance" part, since settings applied by kded module is not only about appearance (e.g. scrollbar behavior)

ngraham accepted this revision.Feb 12 2020, 7:01 PM
This revision is now accepted and ready to land.Feb 12 2020, 7:01 PM
Closed by commit R99:ddc9187adbc5: Provide better name for GTK Settings Sync service (authored by gikari). · Explain WhyFeb 12 2020, 7:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/gtkconfig.json (4 lines)

Diff 75574

View Options

kded/gtkconfig.json

Loading...