Differential D27072

[Colors KCM] Fix roles mixup
ClosedPublic
Actions

Authored by broulik on Jan 31 2020, 4:01 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R119:43001f7977af: [Colors KCM] Fix roles mixup
Summary

There were two role enums that became out of sync, breaking e.g. editing user themes ("override" mode).

Test Plan

5.18
I can edit my own themes directly without Save As again

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 31 2020, 4:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 4:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 31 2020, 4:01 PM
ngraham accepted this revision.Jan 31 2020, 4:49 PM
ngraham added a subscriber: ngraham.

Nice catch, this had been mildly bugging me.

This revision is now accepted and ready to land.Jan 31 2020, 4:49 PM
Closed by commit R119:43001f7977af: [Colors KCM] Fix roles mixup (authored by broulik). · Explain WhyFeb 3 2020, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74899

View Options

kcms/colors/colors.h

Loading...
View Options

kcms/colors/colors.cpp

Loading...
View Options

kcms/colors/filterproxymodel.cpp

Loading...