API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible
ClosedPublic

Authored by kossebau on Fri, Jan 31, 1:23 PM.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Fri, Jan 31, 1:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFri, Jan 31, 1:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Fri, Jan 31, 1:23 PM

@davidre: looking at the setter methods, I am also tempted to add early returns in case of no change. but I do not want to get in the way with your qpainter patch (good work), so waiting :)

davidre added inline comments.Fri, Jan 31, 1:30 PM
src/kmessagewidget.h
258

I think the close button is visible by default, isn't it?

kossebau added inline comments.Fri, Jan 31, 1:34 PM
src/kmessagewidget.h
258

Good catch. I fooled myself with having qt designer showing me still the file version with

<property name="closeButtonVisible">
    <bool>false</bool>
</property>

where I though it was the clean one.

kossebau updated this revision to Diff 74778.Fri, Jan 31, 1:37 PM

fix default visible=true

davidre accepted this revision.Fri, Jan 31, 1:37 PM
This revision is now accepted and ready to land.Fri, Jan 31, 1:37 PM
This revision was automatically updated to reflect the committed changes.
kossebau marked an inline comment as done.