When the "Lock Screen:" checkbox gets disabled the timeout spin box gets disabled too.
But the spin box is still enabled when the checkbox is disabled if the module is loaded.
Details
Details
- Reviewers
mart ervin - Commits
- R133:b060c853b4cd: Fix disabeling of autolock timeout
Disable screenlocking and restart module. The spin box should be disabled.
Before:
https://phabricator.kde.org/file/data/u6vxui546tvyluaoyo4l/PHID-FILE-b3uowaz5ar2xk7buwt6r/edit_before.png
Diff Detail
Diff Detail
- Repository
- R133 KScreenLocker
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks like it's caused by the initial state of the ui file being "wrong" (checkbox unchecked and spinbox enabled), what about simply having the spinbox disabled in the ui file? Maybe we miss a connect there too. It's the kind of ui specific details I try to push out of the C++ file.
Comment Actions
Thats a good point, the issue is that the validation slot gets only triggered if the value gets changed.
If the automatic locking is disabled the value does not change and no signal gets triggered.
Setting the spin box disabled by default is then the easiest solution :-)
Comment Actions
Well, I already accepted it, I thought you pushed long ago (and I suspect it got overlooked by the other potential reviewers). :-)
Comment Actions
I don't have a developer account, but I am going to apply for one.
May I enter your name as a supporter?
Comment Actions
Ah didn't know! I assumed you could push... But yeah, you authored a few patches now, time to apply for a developer account. You can put my name indeed.