Differential D27062

Handle 410 Gone errors during Calendar sync
ClosedPublic
Actions

Authored by gbs on Jan 31 2020, 12:36 PM.

Details

Reviewers
mlaurent
dvratil
Commits
R477:17fedad11cba: Handle 410 Gone errors during Calendar sync
Summary

According to https://developers.google.com/calendar/v3/errors, the server can return a 410 error if the syncToken or updatedMin is too old.
There is already code to preemptively request a full sync, but specifically for the "Contacts" calendar the server-side limit is much lower than usual, generating these errors and preventing sync.

Test Plan
  • Set last sync for "Contacts" calendar to five days ago.
  • Observe 410 error being returned.
  • Verify that a full sync is performed.

Diff Detail

Repository
R477 KGAPI Library
Branch
release/19.12
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21902
Build 21920: arc lint + arc unit
gbs created this revision.Jan 31 2020, 12:36 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 31 2020, 12:36 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gbs requested review of this revision.Jan 31 2020, 12:36 PM
dvratil accepted this revision.Feb 1 2020, 9:02 AM

Nice, thanks!

This revision is now accepted and ready to land.Feb 1 2020, 9:02 AM
lbeltrame added a subscriber: lbeltrame.Feb 1 2020, 9:15 AM

@gbs Do you have commit access? Or do you want someone to commit this change on your behalf?

gbs added a comment.Feb 1 2020, 12:10 PM

No, I don't. Can someone land this for me?

Closed by commit R477:17fedad11cba: Handle 410 Gone errors during Calendar sync (authored by gbs, committed by krop). · Explain WhyFeb 1 2020, 12:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/calendar/eventfetchjob.cpp (16 lines)
Msrc/core/job.cpp (7 lines)

Diff 74763

View Options

src/calendar/eventfetchjob.cpp

Loading...
View Options

src/core/job.cpp

Loading...