Differential D27054

Syncronise environment to user systemd session
ClosedPublic
Actions

Authored by davidedmundson on Jan 31 2020, 10:12 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R120:77f418500e56: Syncronise environment to user systemd session
Summary

Equivalent of dbus-update-activation-environment but in runtime

Test Plan

Changed cursor theme (with some additional fixes there)
Checked the systemd env via the property on manager1.
It had changed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptJan 31 2020, 10:12 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Jan 31 2020, 10:12 AM
broulik added a subscriber: broulik.Jan 31 2020, 10:17 AM
broulik added inline comments.
libkworkspace/updatelaunchenvjob.cpp
105

Coding style

106

Does this need some form of escaping?

109

You probably want to send systemdActivationMsg

davidedmundson marked 2 inline comments as done.Jan 31 2020, 10:36 AM
davidedmundson added inline comments.
libkworkspace/updatelaunchenvjob.cpp
106

I don't think so.

you can't have an = in your var name
and that's the only part that matters

davidedmundson planned changes to this revision.Jan 31 2020, 10:43 AM

hold on, I fixed all this.

stupid phab

davidedmundson updated this revision to Diff 74755.Jan 31 2020, 10:51 AM

update properly this time

broulik accepted this revision.Feb 10 2020, 8:04 AM
This revision is now accepted and ready to land.Feb 10 2020, 8:04 AM
Closed by commit R120:77f418500e56: Syncronise environment to user systemd session (authored by davidedmundson). · Explain WhyFeb 10 2020, 9:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mlibkworkspace/updatelaunchenvjob.cpp (11 lines)

Diff 75335

View Options

libkworkspace/updatelaunchenvjob.cpp

Loading...