It's more intuitive.
- Group Reviewers
- R108:85c099936ec8: Use QRect::moveRight() and QRect::moveBottom() in XdgShellClient…
Relevant tests pass.
or to rephrase zzag:
.right() is off by one
.setRight is off by one
so it cancels out.
Personally I find it so difficult to parse that it's easier to just boycott the method.
Everyone who comes across it and is aware of QRect's ridiculousness ends up having to do a load of additional checking in their heads anyway.
Though we don't have a kwin policy on that and we use QRect::right/bottom in other places, so I can't have a formal objection here.
I just approved another patch that used setRight setBottom in the same method, so we may as well be consistent.
What I meant, was: you can ship this given we also use setRight(other.right()) elsewhere
I just can't press the button now that it's abandoned.