Differential D27037

[Notifications] Fixup setSourceModel
ClosedPublic
Actions

Authored by broulik on Jan 30 2020, 2:58 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R120:1c0c8ddef430: [Notifications] Fixup setSourceModel
Summary

Qt says to do a proper model reset in this method.
I also noticed something funky going on with the LimitedRowCountProxyModel not showing any data which went away with this.

Test Plan

5.18

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 30 2020, 2:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2020, 2:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 30 2020, 2:58 PM
davidedmundson added a subscriber: davidedmundson.Feb 3 2020, 7:49 PM

QAbstractSortFilterProxyModel has docs that say you need it, but QSortFilterProxyModel which you inherit from does reset the model in setSourceModel.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2020, 8:51 AM
Closed by commit R120:1c0c8ddef430: [Notifications] Fixup setSourceModel (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74984

View Options

libnotificationmanager/limitedrowcountproxymodel.cpp

Loading...
View Options

libnotificationmanager/notificationgroupcollapsingproxymodel.cpp

Loading...