Differential D27034

Fix message box when passing a remote url that includes a file
ClosedPublic
Actions

Authored by apol on Jan 30 2020, 2:38 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
Commits
R135:317a899dc774: Fix message box when passing a remote url that includes a file
Summary

The if was negated, I assume it was a typo

Test Plan

I don't get the following screenshot anymore

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21854
Build 21872: arc lint + arc unit
apol created this revision.Jan 30 2020, 2:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 30 2020, 2:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jan 30 2020, 2:38 PM
ngraham accepted this revision.Jan 30 2020, 3:25 PM
This revision is now accepted and ready to land.Jan 30 2020, 3:25 PM
Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). · Explain WhyJan 30 2020, 7:39 PM
This revision was automatically updated to reflect the committed changes.
sandsmark added a subscriber: sandsmark.Jun 7 2020, 5:36 PM

This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename.

Revision Contents
Changeset List

Diff 74692

View Options

src/platformtheme/kdeplatformfiledialoghelper.cpp

Loading...