Differential D27032

Enable adding a place as first item.
AbandonedPublic
Actions

Authored by gvgeo on Jan 30 2020, 12:39 PM.

Details

Reviewers
meven
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

Fix add place at last item.
And utilize adding a place as first item.

Depends on D26983

Test Plan

Drag and drop a folder at the top and the bottom of places panel.

Diff Detail

Repository
R318 Dolphin
Branch
addLastPlace (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21847
Build 21865: arc lint + arc unit
gvgeo created this revision.Jan 30 2020, 12:39 PM
Restricted Application added a subscriber: kfm-devel. · View Herald TranscriptJan 30 2020, 12:39 PM
gvgeo requested review of this revision.Jan 30 2020, 12:39 PM
ngraham accepted this revision.Mar 9 2020, 6:41 PM
ngraham added subscribers: broulik, ngraham.

@broulik I know you have some familiarity with this code; does the change make sense to you in conjunction with D26983?

This revision is now accepted and ready to land.Mar 9 2020, 6:41 PM
gvgeo abandoned this revision.Mar 18 2020, 8:16 AM

Base patch was abandoned.

Revision Contents
Changeset List

Diff 74682

View Options

src/panels/places/placesitemmodel.cpp

Loading...