Differential D2703

Fix applets not being added on service restart
ClosedPublic
Actions

Authored by davidedmundson on Sep 8 2016, 8:32 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:62ac5cd17b00: Fix applets not being added on service restart
R871:f148bdaf2c10: Fix applets not being added on service restart
R871:62ac5cd17b00: Fix applets not being added on service restart
R120:f148bdaf2c10: Fix applets not being added on service restart
Summary

Applet::destroy doesn't delete the applet from Containment::applets in
the same event. Potentially a dbus activated service being restarted can
be added in this time, causing us to try adding a new applet with the
same ID before the first object is deleted.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6530.Sep 8 2016, 8:32 AM
davidedmundson retitled this revision from to Fix applets not being added on service restart.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2016, 8:32 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 9 2016, 9:38 AM
mart added a reviewer: mart.
mart added a subscriber: mart.

as discussed would be nice to have containment::applets updating immediately, but not yet, 5.8 must work with non fixed frameworks as well, so +2

This revision is now accepted and ready to land.Sep 9 2016, 9:38 AM
Closed by commit R120:62ac5cd17b00: Fix applets not being added on service restart (authored by davidedmundson). · Explain WhySep 9 2016, 11:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplets/systemtray/systemtray.cpp (6 lines)

Diff 6582

View Options

applets/systemtray/systemtray.cpp

Loading...