Differential D27025

Add signals for udev events with actions bind and unbind
ClosedPublic
Actions

Authored by meven on Jan 30 2020, 11:02 AM.

Details

Reviewers
broulik
ervin
Commits
R245:8036f148fb66: Add signals for udev events with actions bind and unbind
Summary

Prevents warnings such as :

UdevQt: unhandled device action "bind"
UdevQt: unhandled device action "unbind"

When pluging in/out usb sticks

Diff Detail

Repository
R245 Solid
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jan 30 2020, 11:02 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 30 2020, 11:02 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Jan 30 2020, 11:02 AM
meven edited reviewers, added: ervin; removed: Plasma.Jan 30 2020, 11:02 AM
broulik requested changes to this revision.Jan 30 2020, 11:51 AM
broulik added inline comments.
src/solid/devices/backends/shared/udevqtclient.cpp
119

Can you instead add signals for those, just for completeness' sake? deviceOnlined is also not used but still exists

This revision now requires changes to proceed.Jan 30 2020, 11:51 AM
meven retitled this revision from Ignore udev monitoring notifications with actions bind and unbind to Add signals for udev events with actions bind and unbind.Jan 30 2020, 12:42 PM
meven updated this revision to Diff 74683.Jan 30 2020, 12:44 PM

Add signals for bind/unbind actions

meven marked an inline comment as done.Jan 30 2020, 12:45 PM
broulik added a comment.Jan 30 2020, 12:49 PM

I think it's "bound"

broulik accepted this revision.Jan 30 2020, 12:49 PM
This revision is now accepted and ready to land.Jan 30 2020, 12:49 PM
meven updated this revision to Diff 74684.Jan 30 2020, 12:50 PM

s/binded/ound

Closed by commit R245:8036f148fb66: Add signals for udev events with actions bind and unbind (authored by meven). · Explain WhyJan 30 2020, 12:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74685

View Options

src/solid/devices/backends/shared/udevqtclient.h

Loading...
View Options

src/solid/devices/backends/shared/udevqtclient.cpp

Loading...