I suspect this will fix a few bugs whilst we're at it.
There were a lot running after startplasma has started, so wouldn't have been synced properly to the DBus env.

kcms/krdb/krdb.cpp
39–40	I don't understand why this changes

This revision is now accepted and ready to land.Jan 30 2020, 10:43 AM

broulik added inline comments.Jan 30 2020, 10:46 AM

kcms/krdb/krdb.cpp
39–40	I don't either but it wouldn't build without.

Closed by commit R119:9e3fd9215245: Port to UpdateLaunchEnvJob (authored by broulik). · Explain WhyJan 30 2020, 10:57 AM

This revision was automatically updated to reflect the committed changes.

We haven't called start on any of the jobs, so they do nothing

Also given they're kjobs do we want:

auto job = new UpdateEnvJob()
so we don't delete the job immediately?

Revision Contents
Changeset List

			Path	Packages
M			kcms/colors/CMakeLists.txt (3 lines)
M			kcms/cursortheme/CMakeLists.txt (5 lines)
M			kcms/cursortheme/kcmcursortheme.cpp (8 lines)
M			kcms/fonts/CMakeLists.txt (6 lines)
M			kcms/krdb/krdb.cpp (9 lines)
M			kcms/lookandfeel/CMakeLists.txt (7 lines)
M			kcms/lookandfeel/autotests/CMakeLists.txt (4 lines)
M			kcms/lookandfeel/kcm.cpp (11 lines)
M			kcms/mouse/CMakeLists.txt (5 lines)
M			kcms/mouse/backends/x11/x11_backend.cpp (9 lines)
M			kcms/style/CMakeLists.txt (3 lines)