Add error parser for typical QML runtime errors that make the error
outputs clickable.
Details
Details
- Reviewers
kfunk - Group Reviewers
KDevelop - Commits
- R32:dbd953ef002e: Merge remote-tracking branch 'origin/5.0'
R32:e0348fecc9fb: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:fae696a1756d: Respect KDE HIG
R32:177d78911259: Make Alt back the magic key
R32:47916dba1715: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:d51f000d0e22: Merge remote-tracking branch 'origin/5.0'
R32:f8ed7790dfb3: Merge remote-tracking branch 'origin/5.0'
R32:fe5a1073d627: Remove recovery
R32:c2c112593714: Merge branch '5.0'
R32:aa8b3ddbcaec: Merge remote-tracking branch 'origin/5.0'
R32:72add0f00cae: Fix build without Grantlee
R32:94a73b0cb638: Add mock objects for IDebugSession related classes
R32:b514586da51e: Merge branch '5.0'
R32:6f9c404ea927: Merge remote-tracking branch 'origin/5.0'
R32:1b5cee6136aa: Merge remote-tracking branch 'origin/5.0'
R32:ce0e61c9c9bf: Merge branch '5.0'
R32:02d8e5cec23b: Fix test. Due to latest change OutputWidget have 10 actions by default.
R32:e295a229be03: Merge remote-tracking branch 'origin/5.0'
R32:f36dcd6a615a: Merge branch '5.0'
R32:3d531eba3fa6: Fix source/build directory mapping when in the top-level dir
R32:aee806fdf0ff: Prevent crash if ::effectiveCommandLine is empty
R32:e929ed6900a9: Sync wording to related messages.
R32:cede3bb8daa4: Merge remote-tracking branch 'origin/5.0'
R32:845daf2b68ec: Merge remote-tracking branch 'origin/5.0'
R32:6ef03a47e4c4: Merge remote-tracking branch 'origin/5.0'
R32:d0596e4b3c60: Merge remote-tracking branch 'origin/5.0'
R32:8a6b56567677: Merge remote-tracking branch 'origin/5.0'
R32:c66c2c2c6428: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:12b26bfff4a5: Merge branch '5.0'
R32:5d91568a9077: Merge remote-tracking branch 'origin/5.0'
R32:ccdf6c4b4bbd: Merge remote-tracking branch 'origin/5.0'
R32:00647b89a87c: Merge remote-tracking branch 'origin/5.0'
R32:74c3a618db39: Remove QtQuick1 dependency
R32:664d2fcdc112: Merge remote-tracking branch 'origin/5.0'
R32:77b140790d8a: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:dce32ca92a3f: Merge remote-tracking branch 'origin/5.0'
R32:9116377a431f: Merge branch 'master' of git.kde.org:kdevplatform
R32:18cd9afc6663: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:3b56cc1b08e0: Merge branch '5.0'
R32:151b650d3ce7: Merge branch '5.0'
R32:b7cdd2ade673: Respect HIG: "Watch this" -> "Watch This"
R32:95795f139142: Merge remote-tracking branch 'origin/5.0'
R32:6fa5d5a24ef6: Document Switcher: Include the frame width when setting the fixed size
R32:e418ba368473: Merge remote-tracking branch 'origin/5.0'
R32:945523f2aa0d: CMake: Fix stale reference to source file
R32:f9d906ed3658: Merge branch '5.0'
R32:7cac941ea94f: Project controller: make displaying project config dialog async
R32:b516f361e043: Merge remote-tracking branch 'origin/5.0'
R32:92fcb27d7b7f: Merge remote-tracking branch 'origin/5.0'
R32:dc2bec7c6de6: Bump plugin API version
R32:8d0fcb86a686: Merge remote-tracking branch 'origin/5.0'
R32:a1b948966c63: Register the patch-review plugin as language support for x-diff
R32:1ace5cd60331: Revert "Get back to showing the tooltip with Alt"
R32:c387ff11e5d6: Merge remote-tracking branch 'origin/5.0'
R32:62172eeaa9fc: Rename namespace GDBDebugger to KDevMI::GDB
R32:24516ea80a99: Merge remote-tracking branch 'origin/5.0'
R32:77dd39fcbd0a: Merge remote-tracking branch 'origin/5.0'
R32:aac4daa61a38: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:07d57ecb533a: Merge remote-tracking branch 'origin/5.0'
R32:06d782734555: [Run Controller] Use desktopFileName() instead of hardcoding a now wrong…
R32:2277c6d5b570: ProblemTreeView::contextMenuEvent: Refactor
R32:56fec7b16fc9: Merge remote-tracking branch 'origin/5.0'
R32:718a27f01efc: Merge remote-tracking branch 'origin/5.0'
R32:704d1ac45c60: Refactor the dependencies widget into a separate file
R32:5256d0655a8b: Merge remote-tracking branch 'origin/5.0'
R32:7e5caa87f517: Merge branch '5.0'
R32:fe976f84222f: KDevPlatform changes for supporting the -iframework and -F header search path…
R32:e7c20fda43c0: Merge remote-tracking branch 'origin/5.0'
R32:3deba89dbded: i18n: typo fixes
R32:821435c77700: Remove the redundant scope filtering in problem store
R32:58b17f4766da: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:3439495fb969: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:f5a5b00a10a7: Merge branch '5.0'
R32:dbdf1dcdf3d7: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:1d9ad33af291: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:5594ef9148ea: Remove unneeded cast
R32:6054c9b41731: Compilation fix, presumably for older Qt versions.
R32:93abae00efeb: Merge remote-tracking branch 'origin/1.7'
R32:156a76706991: Merge remote-tracking branch 'origin/5.0'
R32:3be28d8868ae: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:b79837e77958: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:580082f090f2: Merge branch '5.0'
R32:7091419bb1b1: Keep patch-review tabs ordered correctly and enhance local patch support
R32:6909b76b4924: Merge branch '5.0'
R32:380460b74ee9: Merge remote-tracking branch 'origin/5.0'
R32:d859f725a3cd: Merge remote-tracking branch 'origin/5.0'
R32:3aa8dd4260d7: navigation tooltip: hide when scroll position is changed
R32:2fec160106be: Restore system environment for subprocesses
R32:7bd349a9bfd5: Merge remote-tracking branch 'origin/5.0'
R32:e5c85d694551: Merge remote-tracking branch 'origin/5.0'
R32:dfa608ab1426: Merge remote-tracking branch 'origin/5.0'
R32:7a61a3f6ab89: Remember Filesystem ToolView's location in each session
R32:8ba9259d0013: Merge remote-tracking branch 'origin/5.0'
R32:a20f2c360880: Merge remote-tracking branch 'origin/5.0'
R32:5724d12d69aa: Merge branch '5.0'
R32:0cef69e91a4b: Merge remote-tracking branch 'origin/5.0'
R32:25385121a112: Merge remote-tracking branch 'origin/5.0'
R32:1c6e0c79ee0f: Work around gcc 4.8 bug and fix raw string literal
R32:82404d568b1e: Merge branch '5.0'
R32:55a80426005d: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:c0626300e1c1: [OS X] Show job progress in the Dock tile.
R32:70ef09a0e7ba: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:1c66be671aaf: Merge remote-tracking branch 'origin/5.0'
R32:82d6d702ccaf: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:8bf465b4ca69: Merge remote-tracking branch 'origin/5.0'
R32:22ade7a08a11: Don't close documents when saving
R32:dfc47ce5d49f: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:95550c87148c: Fix Bug 333759 Variables tool view not in sync with frame stack view.
R32:0fba52804ad5: removes a link command from the toplevel CMakeLists.txt that was added by my…
R32:af525a7e7200: Merge branch '5.0'
R32:d880a35cf1d7: Merge remote-tracking branch 'origin/5.0'
R32:6c50c9f70546: Merge branch '5.0'
R32:b1a7f6d01b45: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:7a9bf29dbc08: Parse MSVC compile errors Fixes T602
R32:728db7e56897: Merge branch '5.0'
R32:4dd0b13e6231: Minor code cleanup
R32:938f1f7f1444: Implement color scheme selection from these installed in the system using…
R32:32d7be78f997: Update mailing list address in Mainpage.dox files.
R32:833496841341: Merge remote-tracking branch 'origin/5.0'
R32:6d1de1544403: Merge branch 'master' of git://anongit.kde.org/kdevplatform
R32:8c9f25a69e65: Respect KDE HIG
R32:7ae3b04935e9: Revert "Work around gcc 4.8 bug and fix raw string literal"
R32:1dd87ec852c5: Add Provider URLs to the two knsrc files
R32:64a952396fd8: code cleanup: remove sublime "thickness" concept
R32:e10eb3cf30f4: Merge remote-tracking branch 'origin/5.0'
R32:e6eff31cd672: Merge remote-tracking branch 'origin/5.0'
R32:aed4a37df6d7: Merge branch '5.0'
R32:d7b24a732c42: Merge remote-tracking branch 'origin/5.0'
R32:e65556ec248e: Merge remote-tracking branch 'origin/5.0'
R32:b46b4629b913: Merge remote-tracking branch 'origin/5.0'
R32:9b8b0b9c130a: Always use a buddy view if it is explicitly set by the caller
R32:2841d6078b5a: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:b458968cdcd4: Let ProblemsView inherit from QWidget
R32:565219a3cb82: Show job progress in Task Manager
R32:a4e63897063f: Merge remote-tracking branch 'origin/5.0'
R32:0e9c145fcd6d: Merge remote-tracking branch 'origin/5.0'
R32:4a043ee51dab: Merge branch '5.0'
R32:fdde2f2c3299: Merge remote-tracking branch 'origin/5.0'
R32:8b4a71d51c79: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:a0f1d2b55865: Merge branch '5.0'
R32:6f71da7e2388: Merge branch '5.0'
R32:74ff1c897a31: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:88e624ca585d: fixuifiles
R32:2c851ba5ef4e: Merge branch '5.0'
R32:e148f66ca5ac: Merge remote-tracking branch 'origin/5.0'
R32:21ac8dffa5a2: Merge remote-tracking branch 'origin/5.0'
R32:469be3f74f88: Merge remote-tracking branch 'origin/5.0'
R32:d3c4005e521f: Merge remote-tracking branch 'origin/5.0'
R32:a7d916528785: Merge remote-tracking branch 'origin/5.0'
R32:522b087e306b: Install the DependenciesWidget as part of the KDevProject library
R32:e296ae973279: Merge remote-tracking branch 'origin/5.0'
R32:c8ef3eeea53a: Merge remote-tracking branch 'origin/1.7'
R32:2751ad0ae8c5: Merge remote-tracking branch 'origin/5.0'
R32:6dc7643927cb: Merge remote-tracking branch 'origin/5.0'
R32:50cda3f8071b: preserve existing windowIcons via QIcon::fromTheme's fallback
R32:caec092c806c: Merge branch '5.0'
R32:d9a7ee0f5757: Merge remote-tracking branch 'origin/5.0'
R32:0c5947ecac31: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:303b9daa4c61: Merge remote-tracking branch 'origin/5.0'
R32:1b02bbaaade1: Add unit tests for IVariableController
R32:dfa70d42646a: SVN_SILENT made messages (.desktop file) - always resolve ours
R32:deed000f34a2: Merge remote-tracking branch 'origin/5.0'
manual testing
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Why match the error string at all and not just the filename? Is there a realistic case where that is not what you want?
Comment Actions
You mean a general rule matching every line that contains a file path? Actually, I am not sure about catching too many false-positives by this approach, e.g. when printing a filepath by a debug statement. Other opinions?
Comment Actions
Just at the beginning of the line, i.e. basically the intersection of the two expressions you added ;)
Even if it matches a false positive, that just means you can jump there as well ...
Comment Actions
Sorry, arc diff apparently completely screwed the diff... Will close it and add another review :/