Differential D26990

Allow setting ItemsModel engine to either KNSCore or KNSQuick engine
Needs ReviewPublic
Actions

Authored by leinir on Jan 29 2020, 1:52 PM.

Details

Reviewers
aacid
Group Reviewers
KNewStuff
Frameworks
Summary

This fixes a regression caused by the initial work to bring KNSQuick
up to feature parity with KNewStuff's widget implementation. It was
unfortunately not caught during the work, but better late than never.
(it should not cause any other regressions, and is further slightly
more stable logically than the old code)

Diff Detail

Repository
R304 KNewStuff
Branch
allow-setting-qtquick-itemsmodel-engine-with-either-engine-type (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21783
Build 21801: arc lint + arc unit
leinir created this revision.Jan 29 2020, 1:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 29 2020, 1:52 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Jan 29 2020, 1:52 PM
leinir updated this revision to Diff 74574.Jan 29 2020, 1:53 PM
  • Remove some unrelated changes
aacid added a comment.Jan 29 2020, 9:41 PM

Seems reasonable to me.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/quickitemsmodel.cpp (31 lines)

Diff 74574

View Options

src/qtquick/quickitemsmodel.cpp

Loading...