Differential D26988

[scripting] Expose Workspace::sendClientToDesktop()
ClosedPublic
Actions

Authored by zzag on Jan 29 2020, 1:39 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:76297196e898: [scripting] Expose Workspace::sendClientToDesktop()
R108:ea8e28337eb1: Merge branch 'Plasma/5.18'
Summary

BUG: 416093
FIXED-IN: 5.18.0

Test Plan

Only compile-time check.

Diff Detail

Repository
R108 KWin
Branch
scripting-expose-send-client-to-desktop
Lint
Lint ErrorsExcuse: asdf
SeverityLocationCodeMessage
Errorutils.h:123CppcheckunknownMacro
Errorutils.h:123CppcheckunknownMacro
Errorutils.h:123CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 21779
Build 21797: arc lint + arc unit
zzag created this revision.Jan 29 2020, 1:39 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 29 2020, 1:39 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 29 2020, 1:39 PM
zzag updated this revision to Diff 74567.Jan 29 2020, 1:41 PM

no return

davidedmundson accepted this revision.Jan 29 2020, 1:41 PM
This revision is now accepted and ready to land.Jan 29 2020, 1:41 PM
zzag updated this revision to Diff 74575.Jan 29 2020, 1:54 PM

Let's for now leave things as is and not check screen in Workspace::sendClientToScreen()

We can revisit this later.

zzag added a comment.Jan 29 2020, 1:55 PM

I'm targeting Plasma/5.18. Is it okay?

zzag edited the summary of this revision. (Show Details)Jan 29 2020, 2:14 PM
Closed by commit R108:76297196e898: [scripting] Expose Workspace::sendClientToDesktop() (authored by zzag). · Explain WhyJan 29 2020, 3:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74567

View Options

scripting/workspace_wrapper.h

Loading...
View Options

scripting/workspace_wrapper.cpp

Loading...
View Options

useractions.cpp

Loading...
View Options

workspace.cpp

Loading...