Add a place, by drag into empty area of the panel
AbandonedPublic

Authored by gvgeo on Jan 29 2020, 10:56 AM.

Details

Reviewers
ngraham
Group Reviewers
Dolphin
Summary

Enable adding a place from empty area.
Fix placing a place as first item.

Depends on D26983
BUG: 403214

Test Plan

Before:
No place was created by dropping into the empty area.
Dropping an item at the top, was placed second.

After:
Drag-and-drop a folder into any empty part of the places panel,
puts it at the bottom of the places section.

Diff Detail

Repository
R318 Dolphin
Branch
empty (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21768
Build 21786: arc lint + arc unit
gvgeo created this revision.Jan 29 2020, 10:56 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJan 29 2020, 10:56 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
gvgeo requested review of this revision.Jan 29 2020, 10:56 AM
gvgeo planned changes to this revision.Jan 30 2020, 12:42 PM

Split changes into 2 patches. Other half is D27032.

gvgeo abandoned this revision.Feb 2 2020, 6:33 AM

This isn't the correct way to do it.

It is better to fix the drop indicator(limit within correct group) KItemListView::showDropIndicator, and give proper index from there.