Fix DownloadPage use of KNS.ItemsModel
ClosedPublic

Authored by aacid on Jan 28 2020, 11:42 PM.

Details

Summary

At some point the framework broke compatibility and stopped affecting the engine.engine and wanted the engine directly

Test Plan

I get something in the DownloadPage now

Diff Detail

Repository
R72 Artikulate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aacid created this revision.Jan 28 2020, 11:42 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 28 2020, 11:42 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
aacid requested review of this revision.Jan 28 2020, 11:42 PM
leinir accepted this revision.Jan 29 2020, 8:47 AM

About half a year ago, yeah - it is a regression, but to ensure people can use it with already-released versions of Frameworks, this'll probably want to go in. Also, since the old code would take either, if people insist on running it against an old version of Frameworks, it should then still work :)

This revision is now accepted and ready to land.Jan 29 2020, 8:47 AM

Also incidentally, i've just posted D26990 which should hopefully alleviate the issue for people with an up-to-date Frameworks but an out-of-date Artikulate ;)

This revision was automatically updated to reflect the committed changes.