Differential D26974

[wayland] Get rid of some duplicated code
ClosedPublic
Actions

Authored by zzag on Jan 28 2020, 10:06 PM.

Details

Reviewers
None
Group Reviewers
KWin
Commits
R108:2cf832cf2915: [wayland] Get rid of some duplicated code
Summary

We duplicate ping code in a few places. This change introduces a dedicated
method for sending ping events to an xdg-toplevel. In long term, it can be
used for sending "test" ping messages at random interval.

Diff Detail

Repository
R108 KWin
Branch
introduce-ping-method
Lint
Lint ErrorsExcuse: asdfasdf
SeverityLocationCodeMessage
Errorinput.h:310CppcheckunknownMacro
Errorinput.h:310CppcheckunknownMacro
Unit
No Unit Test Coverage
Build Status
Buildable 21757
Build 21775: arc lint + arc unit
zzag created this revision.Jan 28 2020, 10:06 PM
Restricted Application added a project: KWin. · View Herald TranscriptJan 28 2020, 10:06 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Jan 28 2020, 10:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2020, 11:18 AM
Closed by commit R108:2cf832cf2915: [wayland] Get rid of some duplicated code (authored by zzag). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mxdgshellclient.h (3 lines)
Mxdgshellclient.cpp (15 lines)

Diff 74535

View Options

xdgshellclient.h

Loading...
View Options

xdgshellclient.cpp

Loading...