make min/maxuid detection more portable
ClosedPublic

Authored by sitter on Jan 28 2020, 1:44 PM.

Details

Summary

the pervious tech had shoddy coverage and was bound to eventually break
because of the rise of /etc/os-release to rule all the proprietary release
files that preceded it.

instead we now set sane default assumptions and attempt to load the actual
default for the specific system from /etc/login.defs (part of shadow source
and should be available on more or less all modern linux systems
https://github.com/shadow-maint/shadow).

Test Plan

max/min detection still works

Diff Detail

Repository
R432 File Sharing (Samba) integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Jan 28 2020, 1:44 PM
sitter created this revision.
ngraham accepted this revision.Jan 28 2020, 4:47 PM

+1, much nicer.

This revision is now accepted and ready to land.Jan 28 2020, 4:47 PM
This revision was automatically updated to reflect the committed changes.