Differential D26962

Fixes multiple KVersionControlPlugin::fileName() calls on entering or updating directory.
ClosedPublic
Actions

Authored by nikolaik on Jan 28 2020, 1:00 PM.

Details

Reviewers
meven
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:d0cbcf9718bb: Fixes multiple KVersionControlPlugin::fileName() calls on entering or updating…
Summary

BUG: 415698
FIXED-IN: 20.04

On each VCS plugin creation corresponding file name is saved (cached) so when we search which VCS plugin is appropriate for current directory we don't need to call KVersionControlPlugin::fileName() again.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nikolaik created this revision.Jan 28 2020, 1:00 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptJan 28 2020, 1:00 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
nikolaik requested review of this revision.Jan 28 2020, 1:00 PM
meven accepted this revision as: meven.Feb 18 2020, 8:13 AM
meven added inline comments.
src/views/versioncontrol/versioncontrolobserver.cpp
326

qAsConst(m_plugins)

This revision is now accepted and ready to land.Feb 18 2020, 8:13 AM
nikolaik updated this revision to Diff 75885.Feb 18 2020, 8:37 AM

Thanks!
Update in response to review comments.

nikolaik marked an inline comment as done.Feb 18 2020, 8:37 AM
meven added inline comments.Feb 18 2020, 9:05 AM
src/views/versioncontrol/versioncontrolobserver.cpp
326

You can const auto &it also

nikolaik updated this revision to Diff 75894.Feb 18 2020, 9:16 AM

Added more constness.

nikolaik marked an inline comment as done.Feb 18 2020, 9:16 AM
meven edited the summary of this revision. (Show Details)Feb 18 2020, 9:54 AM
ngraham accepted this revision.Feb 18 2020, 8:17 PM
Closed by commit R318:d0cbcf9718bb: Fixes multiple KVersionControlPlugin::fileName() calls on entering or updating… (authored by nikolaik, committed by ngraham). · Explain WhyFeb 18 2020, 9:55 PM
This revision was automatically updated to reflect the committed changes.
meven added a comment.Feb 19 2020, 8:18 AM

Thanks @ngraham I had in mine to land this one and the other one

Well done @nikolaik. As you can see, you might need some patience sometimes.

Revision Contents
Changeset List

Diff 75945

View Options

src/views/versioncontrol/versioncontrolobserver.h

Loading...
View Options

src/views/versioncontrol/versioncontrolobserver.cpp

Loading...