Differential D26957

KateModeMenuList: don't overlap the scroll bar
ClosedPublic
Actions

Authored by nibags on Jan 28 2020, 9:16 AM.

Details

Reviewers
cullmann
Group Reviewers
KTextEditor
Commits
R39:6f39d3345273: KateModeMenuList: don't overlap the scroll bar
Summary

According to T9126, the scroll bar will not overlap the list.

Diff Detail

Repository
R39 KTextEditor
Branch
mode-menu-scrollbar-overlap
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21754
Build 21772: arc lint + arc unit
nibags created this revision.Jan 28 2020, 9:16 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 28 2020, 9:16 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
nibags requested review of this revision.Jan 28 2020, 9:16 AM
nibags edited the summary of this revision. (Show Details)Jan 28 2020, 9:18 AM
nibags added reviewers: cullmann, KTextEditor.
anthonyfieroni added a subscriber: anthonyfieroni.Jan 28 2020, 1:49 PM

Don't remove default parameter, it'll break other users.

ngraham added a subscriber: ngraham.Jan 28 2020, 4:34 PM

JFYI Kate has moved to GitLab and most patches are now submitted at https://invent.kde.org/kde/kate.

nibags updated this revision to Diff 74531.Jan 28 2020, 8:47 PM
  • Restore parameters
cullmann accepted this revision.Feb 9 2020, 11:28 AM

This is a patch for KTextEditor, that is still on phab (for good or bad ;=)
I think this is ok, accepting & merging.
Btw., for the default arguments: This is a purely internal class, therefore removing it would have been ok.

This revision is now accepted and ready to land.Feb 9 2020, 11:28 AM
Closed by commit R39:6f39d3345273: KateModeMenuList: don't overlap the scroll bar (authored by nibags, committed by cullmann). · Explain WhyFeb 9 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74531

View Options

src/mode/katemodemenulist.h

Loading...
View Options

src/mode/katemodemenulist.cpp

Loading...