When building the "install" target with a static Kirigami build an error occurs due to the missing file kirigami2_export.h.
Details
Details
- Reviewers
mart apol - Group Reviewers
Kirigami - Commits
- R169:0aa162f2e838: Remove export header from static install
Download Kirigami sources, create build directory, create install directory, and then something similar to:
INSTALL_DIR=$HOME/tmp-install QT_INSTALL_DIR=$HOME/qt-5.12.6 ECM_DIR=$HOME/tmp-install # Assume ECM was also "make installed" into this dir KIRIGAMI_SRC=$HOME/kirigami cmake -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR -DCMAKE_PREFIX_PATH=$QT_INSTALL_DIR;$ECM_DIR $KIRIGAMI_SRC cmake --build . --target install
Before the patch this will fail because of missing kirigami2_export.h file.
Diff Detail
Diff Detail
- Repository
- R169 Kirigami
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
It appears all the sources which reference the export header have an appropriate guard on them:
#ifndef KIRIGAMI_BUILD_TYPE_STATIC
#include <kirigami2_export.h>
#endif
I found these in tabletmodewatcher.h, kirigamipluginfactory.h, platformtheme.h
Comment Actions
Hello,
Just following up on this change review—it all looks good to me. Can we merge it in?
Thanks!