With the other two patches, this aims to make leftMargin consistent in plasmoids. (See https://phabricator.kde.org/D26944 and https://phabricator.kde.org/D26946)
Details
Details
- Reviewers
romangg - Group Reviewers
VDG - Commits
- R104:b0f3fa30d427: fix(plasmoid): add smallSpacing to leftMargin
Before:
After:
Diff Detail
Diff Detail
- Repository
- R104 KScreen
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 22697 Build 22715: arc lint + arc unit
Comment Actions
Hmm, it almost seems like the header in the popup is over too far to the right, and we should fix that (and maybe increase the default margins in the theme: D21813) rather than adding extra margins in every plasmoid.
Comment Actions
Since this patch is for KScreen, you need to follow the commit message guidelines: https://cgit.kde.org/kscreen.git/tree/CONTRIBUTING.md#n22
Comment Actions
Is the commit given by the patch title that I just changed, or do I have to change the commit name somewhere else?
Comment Actions
Depends on if you use in the end arc. Then it's given by the Phab diff title.
I changed it some more. See https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d358/CONTRIBUTING.md#subject.
Patch looks good.