Take screenshot with currently selected options

Authored by davidre on Jan 26 2020, 3:42 PM.



If Spectacle is running and the user activates the shortcut to start Spectacle
while he has the option "Take a new Screenshot" selected use the current settings
ad configured in the window and not those of the last taken Screenshot

BUG: 415688
FIXED-IN: 20.04.0

Test Plan

Open Spectacle, press print screen

Diff Detail

R166 Spectacle
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
davidre created this revision.Jan 26 2020, 3:42 PM
Restricted Application added a project: Spectacle. · View Herald TranscriptJan 26 2020, 3:42 PM
davidre requested review of this revision.Jan 26 2020, 3:42 PM
davidre updated this revision to Diff 74395.Jan 26 2020, 3:43 PM

Remove unrelated change

ngraham accepted this revision.Jan 29 2020, 6:52 PM
This revision is now accepted and ready to land.Jan 29 2020, 6:52 PM

Whoops I say fixed-in 19.12.2 but that patch is only against master. That bug is probably also in stable and here it comes from straight porting. I will look into it and also submit a patch for 19.12

davidre edited the summary of this revision. (Show Details)Jan 31 2020, 9:59 AM

It's harder to fix because on 19.12 we save not the last capture mode but the index of the combobox which doesn't map directly to the capture mode. And I don't want to change what's being saved in the config on stable or duplicate the combobox mapping here (which also is broken) so I will push this only to master

This revision was automatically updated to reflect the committed changes.