Differential D26928

Correctly process font, that has multiple words in family name
ClosedPublic
Actions

Authored by gikari on Jan 26 2020, 3:24 PM.

Details

Reviewers
ngraham
Commits
R99:8bf4efd76430: Correctly process font, that has multiple words in family name
R99:7864ddd557a6: Merge branch 'Plasma/5.18'
Summary

Separate family from other font characteristics with comma. It
partially solves the issue, because font dialog in Fonts KCM
allows you to choose the font with family name, constructed
with the font style.

BUG: 380980
FIXED-IN: 5.18.0

Test Plan
  1. Restart kded5
  2. Change font in Fonts KCM to one, which name consist of two or more words separated with spaces
  3. GTK applications should now correctly use that font

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
apply-font-styles-correctly (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21679
Build 21697: arc lint + arc unit
gikari created this revision.Jan 26 2020, 3:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2020, 3:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gikari requested review of this revision.Jan 26 2020, 3:24 PM
ngraham accepted this revision.Jan 26 2020, 3:47 PM
This revision is now accepted and ready to land.Jan 26 2020, 3:47 PM
davidedmundson added a subscriber: davidedmundson.Jan 26 2020, 4:13 PM

Can't style names have a space too?

Closed by commit R99:8bf4efd76430: Correctly process font, that has multiple words in family name (authored by gikari). · Explain WhyJan 26 2020, 4:18 PM
This revision was automatically updated to reflect the committed changes.
gikari added a comment.Jan 26 2020, 4:32 PM
In D26928#601009, @davidedmundson wrote:

Can't style names have a space too?

If you add comma after style too, it would break font config reading. But there is a workaround for that - you can select font with that style in font family name:

Revision Contents
Changeset List

PathPackages
Mkded/configvalueprovider.cpp (2 lines)

Diff 74393

View Options

kded/configvalueprovider.cpp

Loading...