Differential D26924

[SystemTray] Remove scrolbar paddings
ClosedPublic
Actions

Authored by kmaterka on Jan 26 2020, 10:21 AM.

Details

Reviewers
davidedmundson
broulik
ngraham
nicolasfella
Group Reviewers
Plasma: Workspaces
Plasma
Commits
R120:2f08da60981a: [SystemTray] Remove scrollbar paddings
R120:82d7fd7ab04d: [SystemTray] Remove scrollbar paddings
Summary

Removes additional paddings. Not needed when scrollbar is no longer overlaying content. See: D26530

Test Plan
  1. Open configuration window
  2. No paddings

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21670
Build 21688: arc lint + arc unit
kmaterka requested review of this revision.Jan 26 2020, 10:21 AM
kmaterka created this revision.
kmaterka updated this revision to Diff 74381.Jan 26 2020, 10:24 AM
This comment was removed by kmaterka.
kmaterka updated this revision to Diff 74383.Jan 26 2020, 10:28 AM

Just reverting last update, I will create separate revision.

nicolasfella accepted this revision.Jan 26 2020, 3:58 PM
This revision is now accepted and ready to land.Jan 26 2020, 3:58 PM
ngraham added a comment.Jan 26 2020, 4:25 PM

The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only?

Closed by commit R120:2f08da60981a: [SystemTray] Remove scrollbar paddings (authored by kmaterka). · Explain WhyJan 26 2020, 8:53 PM
This revision was automatically updated to reflect the committed changes.
kmaterka added a comment.Jan 26 2020, 9:12 PM
In D26924#601024, @ngraham wrote:

The scrollbar changes are in 5.18; shouldn't this go to the stable branch instead of master-only?

Yes, sorry, I forgot about this....

ngraham added a comment.Jan 27 2020, 6:10 PM

No worries!

Revision Contents
Changeset List

Diff 74380

View Options

applets/systemtray/package/contents/ui/ConfigEntries.qml

Loading...