Differential D26923

Fix systemtray configuration
ClosedPublic
Actions

Authored by carewolf on Jan 26 2020, 9:46 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma: Workspaces
Commits
R120:ce69fc4ea914: Fix systemtray configuration
Summary

The property currentValue is conflicting making the qml file not run.

Diff Detail

Repository
R120 Plasma Workspace
Branch
Plasma/5.18
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21669
Build 21687: arc lint + arc unit
carewolf created this revision.Jan 26 2020, 9:46 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 26 2020, 9:46 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
carewolf requested review of this revision.Jan 26 2020, 9:46 AM
kmaterka added a subscriber: kmaterka.Jan 26 2020, 9:59 AM

Thanks for noticing! The currentValue property was introduced with QtQuick.Controls 2.14 (Qt 5.14). Very convenient, unfortunately Plasma 5.18 must support Qt 5.12.

BTW. QML import system is stupid (or I am :) ). Apparently, using import QtQuick.Controls 2.5 will not allow you to use currentValue, but it will still conflict...

applets/systemtray/package/contents/ui/ConfigEntries.qml
198

Instead of removing currentValue change it's name. This property is used in KeySequenceItem

269

I won't work in Qt =< 5.13. Just rename currentValue to something not-conflicting.

carewolf updated this revision to Diff 74379.Jan 26 2020, 10:04 AM

Changed name of property instead

kmaterka added a comment.Jan 26 2020, 10:13 AM

Look good for me, but someone else from KDE team needs to approve this.

davidedmundson accepted this revision.Jan 26 2020, 4:17 PM

@konrad you're part of the kde team now. Feel free to approve things you're comfortable with.

This revision is now accepted and ready to land.Jan 26 2020, 4:17 PM
Closed by commit R120:ce69fc4ea914: Fix systemtray configuration (authored by carewolf). · Explain WhyMar 13 2020, 3:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 74379

View Options

applets/systemtray/package/contents/ui/ConfigEntries.qml

Loading...