Handle a crash in full screen requests when the window shows no host list
ClosedPublic

Authored by enriquem on Jan 25 2020, 2:52 PM.

Details

Summary

This patch will tackle https://bugs.kde.org/show_bug.cgi?id=416156 to handle a full screen request when entering krdc and the list is not shown
BUG: 416156

Diff Detail

Repository
R436 KRDC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
enriquem requested review of this revision.Jan 25 2020, 2:52 PM
enriquem created this revision.
enriquem retitled this revision from Handle full screen requests to Handle a crash in full screen requests when the window shows no host list .
enriquem edited the summary of this revision. (Show Details)
cfeck accepted this revision.Jan 25 2020, 3:48 PM
This revision is now accepted and ready to land.Jan 25 2020, 3:48 PM
shubham edited the summary of this revision. (Show Details)Jan 25 2020, 4:00 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a comment.Jan 25 2020, 4:07 PM

Thanks for the investigation! There are more places where m_addressInput is used without a nullptr check, but I didn't analyze the code flow if these can be reached when the m_addressInput widget is not present. Feel free to verify :)

Thanks for the investigation! There are more places where m_addressInput is used without a nullptr check, but I didn't analyze the code flow if these can be reached when the m_addressInput widget is not present. Feel free to verify :)

I looked around and could not find any other instances where m_addressInput is used before it is created. However, during the investigation I found that the command-line option --fullscreen is not honored unless there is also a URL. I will file a new diff for you to consider