[Touchpad plasmoid] Major cleanup
ClosedPublic

Authored by broulik on Sep 7 2016, 9:52 AM.

Details

Summary
  • Use the compact representation for indicating status
  • In the expanded representation just place a button
  • Use declarative bindings as much as possible

BUG: 368192
FIXED-IN: 5.8.0

Test Plan

I just wanted to fix the icon but then decided to give it a major cleanup.

Tested:

  • Enabling / disabling
  • Disabling with no external mouse prompts for confirmation
  • With no touchpad the icon turns gray (and the applet should just hide completely but doesn't work in tray, see below)

I stumbled upon two bugs in system tray:

  • When I have an applet with preferredRepresentation being expandedRepresentation systray tries to be smart and then expands on plasmashell startup and shows an empty spot for fthe applet
  • HiddenStatus applets are still shown in the popup list like PassiveStatus ones

Expanded representation in system tray, this is only accessible when in the popup and clicking the text of the applet instead of its icon. In all other cases clicking the icon just turns it on/off.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6510.Sep 7 2016, 9:52 AM
broulik retitled this revision from to [Touchpad plasmoid] Major cleanup.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptSep 7 2016, 9:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Sep 7 2016, 10:28 AM
mart added a reviewer: mart.
mart added a subscriber: mart.
mart added inline comments.
kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml
37

i don't like it that much, but will need in the future to actually fake mouse events when clicking on the label.
for now there is no other way, so is good to go

This revision is now accepted and ready to land.Sep 7 2016, 10:28 AM
colomar added a subscriber: colomar.Sep 8 2016, 3:15 PM

Looks fine to me

This revision was automatically updated to reflect the committed changes.